Re: [PATCH] IB/ipoib: order:1 failure in ipoib_cm_alloc_rx_skb causes softlockup
From: David Miller <davem@davemloft.net>
Date: 2014-09-12 19:20:25
From: Venkat Venkatsubra <redacted> Date: Fri, 12 Sep 2014 09:15:33 -0700
quoted hunk
@@ -61,6 +61,11 @@ enum ipoib_flush_level { IPOIB_FLUSH_HEAVY }; +#ifdef max +#undef max +#endif +#define max(x, y) (((int)(x) > (int)(y)) ? x : y) + enum { IPOIB_ENCAP_LEN = 4,
This is insanely inappropriate. Use the linux/kernel.h provided max() definition, there is no reason to redefine your own version, ever.