Thread (4 messages) flat view 4 messages, 3 authors, 2014-09-08

Re: [PATCH] net: Fix GRE RX to use skb_transport_header for GRE header offset

From: Tom Herbert <hidden>
Date: 2014-09-08 17:10:06

On Mon, Sep 8, 2014 at 8:50 AM, Eric Dumazet [off-list ref] wrote:
On Mon, 2014-09-08 at 08:29 -0700, Tom Herbert wrote:
quoted
GRE assumes that the GRE header is at skb_network_header +
ip_hrdlen(skb). It is more general to use skb_transport_header
and this allows the possbility of inserting additional header
between IP and GRE (which is what we will done in Generic UDP
Encapsulation for GRE).

Signed-off-by: Tom Herbert <redacted>
---
 net/ipv4/gre_demux.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
I am always confused why you do not include prior Acked-by when you
repost same patch.
Sorry, I'll do that next time.
This forces me to add it again.

Note this should be a net-next patch, right ?
Yes.
Acked-by: Eric Dumazet <edumazet@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help