Re: [PATCH net-next 1/3] net: bpf: consolidate JIT binary allocator
From: David Miller <davem@davemloft.net>
Date: 2014-09-07 23:15:44
From: Daniel Borkmann <redacted> Date: Sat, 6 Sep 2014 11:42:45 +0200
While reviewing the code, I think on s390, the alignment masking seems not to be correct in it's current form, that is, we make sure the first instruction starts at an even address as stated by commit aa2d2c73c21f but masks the start with '& -2' while 2 byte-alignment should rather be '& ~1'.
Both -2 and ~1 are the same value.