Tue, Sep 02, 2014 at 06:08:18AM CEST, Sathya.Perla@Emulex.Com wrote:

quoted

-----Original Message-----
From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]

Hello.

quoted

In the BE3 super-nic profile, the max_tx_qs value can vary for each

function.

quoted

So the driver needs to query this value from FW instead of using the
pre-defined constant BE3_MAX_TX_QS.

quoted

Signed-off-by: Suresh Reddy <redacted>
Signed-off-by: Sathya Perla <redacted>
---
  drivers/net/ethernet/emulex/benet/be_main.c |   13 +++++++++++--
  1 files changed, 11 insertions(+), 2 deletions(-)

quoted

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c

b/drivers/net/ethernet/emulex/benet/be_main.c

quoted

index f3235d1..a30156b 100644

--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c

@@ -3324,10 +3324,19 @@ static void BEx_get_resources(struct

be_adapter *adapter,

quoted

  	 */
  	if (BE2_chip(adapter) || use_sriov ||  (adapter->port_num > 1) ||
  	    !be_physfn(adapter) || (be_is_mc(adapter) &&
-	    !(adapter->function_caps & BE_FUNCTION_CAPS_RSS)))
+	    !(adapter->function_caps & BE_FUNCTION_CAPS_RSS))) {
  		res->max_tx_qs = 1;
-	else
+	} else if (adapter->function_caps &

BE_FUNCTION_CAPS_SUPER_NIC) {

quoted

+		struct be_resources super_nic_res = {0};

    Empty line is needed after declaration.

Ok, will  fix it. Thks.

scripts/checkpatch.pl is your friend :)

quoted

quoted

+		/* On a SuperNIC profile, the driver needs to use the
+		 * GET_PROFILE_CONFIG cmd to query the per-function TXQ

limits

quoted

+		 */
+		be_cmd_get_profile_config(adapter, &super_nic_res, 0);
+		/* Some old versions of BE3 FW don't report max_tx_qs

value */

quoted

+		res->max_tx_qs = super_nic_res.max_tx_qs ? :

BE3_MAX_TX_QS;

quoted

+	} else {
  		res->max_tx_qs = BE3_MAX_TX_QS;
+	}

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html