Thread (3 messages) 3 messages, 3 authors, 2014-08-30

Re: [PATCH (net-next) v3] net: stmmac: fix warning from Sparse for socfpga

From: Giuseppe CAVALLARO <hidden>
Date: 2014-08-28 05:54:13
Also in: lkml

On 8/28/2014 6:59 AM, Ley Foon Tan wrote:
Warning:
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:41:
sparse: cast removes address space of expression
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:122:38:
sparse: incorrect type in assignment (different address spaces)

Signed-off-by: Ley Foon Tan <redacted>
Acked-by: Giuseppe Cavallaro <redacted>
quoted hunk ↗ jump to hunk
---
  drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
index cd613d7..ddc6115 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
@@ -119,8 +119,7 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
  			return -EINVAL;
  		}

-		dwmac->splitter_base = (void *)devm_ioremap_resource(dev,
-			&res_splitter);
+		dwmac->splitter_base = devm_ioremap_resource(dev, &res_splitter);
  		if (!dwmac->splitter_base) {
  			dev_info(dev, "Failed to mapping emac splitter\n");
  			return -EINVAL;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help