[PATCH 0/8] Implement NAPI in et131x · Mark Einon <mark.einon@gmail.com> · 2014-08-20
[PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero · Mark Einon <mark.einon@gmail.com> · 2014-08-20
Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero · Greg KH <gregkh@linuxfoundation.org> · 2014-08-30
Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero · Mark Einon <mark.einon@gmail.com> · 2014-08-31
Re: [PATCH 3/8] staging: et131x: Use for loop to initialise contiguous registers to zero · Greg KH <gregkh@linuxfoundation.org> · 2014-08-31
[PATCH 2/8] staging: et131x: Don't handle rx/tx packets when changing mtu · Mark Einon <mark.einon@gmail.com> · 2014-08-20
[PATCH 8/8] staging: et131x: Implement NAPI support · Mark Einon <mark.einon@gmail.com> · 2014-08-20
Re: [PATCH 8/8] staging: et131x: Implement NAPI support · Stephen Hemminger <stephen@networkplumber.org> · 2014-08-21
Re: [PATCH 8/8] staging: et131x: Implement NAPI support · Mark Einon <mark.einon@gmail.com> · 2014-08-21
Re: [PATCH 8/8] staging: et131x: Implement NAPI support · Stephen Hemminger <stephen@networkplumber.org> · 2014-08-21
Re: [PATCH 8/8] staging: et131x: Implement NAPI support · Mark Einon <mark.einon@gmail.com> · 2014-08-21
[PATCH 7/8] staging: et131x: Fix ET_INTR_TXDMA_ISR register name typo · Mark Einon <mark.einon@gmail.com> · 2014-08-20
[PATCH 6/8] staging: et131x: Rename NUM_PACKETS_HANDLED to MAX_PACKETS_HANDLED · Mark Einon <mark.einon@gmail.com> · 2014-08-20
[PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable · Mark Einon <mark.einon@gmail.com> · 2014-08-20
Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable · Fabio Estevam <festevam@gmail.com> · 2014-08-20
Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable · Mark Einon <mark.einon@gmail.com> · 2014-08-21
Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable · Fabio Estevam <festevam@gmail.com> · 2014-08-21
Re: [PATCH 5/8] staging: et131x: Remove unnecessary i2c_wack variable · Mark Einon <mark.einon@gmail.com> · 2014-08-21
[PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat registers to zero · Mark Einon <mark.einon@gmail.com> · 2014-08-20
RE: [PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat registers to zero · David Laight <hidden> · 2014-08-21
Re: [PATCH 4/8] staging: et131x: Use for loop to initialise contiguous macstat registers to zero · Mark Einon <mark.einon@gmail.com> · 2014-08-21
[PATCH 1/8] staging: et131x: Use eth_mac_addr() instead of duplicating the functionality · Mark Einon <mark.einon@gmail.com> · 2014-08-20

Re: [PATCH 8/8] staging: et131x: Implement NAPI support

From: Mark Einon <mark.einon@gmail.com>
Date: 2014-08-21 09:25:16
Also in: lkml

On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:

On Wed, 20 Aug 2014 23:17:58 +0100
Mark Einon [off-list ref] wrote:

quoted

-	bool done = true;
+	int count = 0;
+	int limit = budget;
+	bool not_done = false;

Don't use negative variables. Better to keep the original done variable.

Fair comment, I'll send a v2.

Cheers,

Mark

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help