Re: [PATCH] net: phy: smsc: move smsc_phy_config_init reset part in a soft_reset function
From: Sergei Shtylyov <hidden>
Date: 2014-08-15 14:36:44
Also in:
lkml
Hello. On 08/15/2014 11:52 AM, Gwenhael Goavec-Merou wrote:
On the one hand, phy_device.c provides a generic reset function if the phy driver does not provide a soft_reset pointer. This generic reset does not take into account the state of the phy, with a potential failure if the phy is in powerdown mode. On the other hand, smsc driver provides a function with both correct reset behaviour and configuration.
This patch moves the reset part into a new smsc_phy_reset function and provides the soft_reset pointer to have a correct reset behaviour by default.
Signed-off-by: Gwenhael Goavec-Merou <redacted> --- drivers/net/phy/smsc.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 180c494..fda13f4 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c
[...]
quoted hunk ↗ jump to hunk
@@ -142,6 +147,7 @@ static struct phy_driver smsc_phy_driver[] = { .config_aneg = genphy_config_aneg, .read_status = genphy_read_status, .config_init = smsc_phy_config_init, + .soft_reset = smsc_phy_reset,
Please align with the other ='s above here and below.
WBR, Sergei