Thread (11 messages) flat view 11 messages, 3 authors, 2014-08-12

Re: [PATCH] allow setting wiphy.perm_addr after driver probe

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2014-08-11 23:56:26
Also in: linux-wireless, lkml

Hi Daniel,
quoted
Internally it might do that, but I do not see it exposing the
NL80211_ATTR_MAC when you get the attributes for wiphy.
When wlan0 is created, it can be created with its own MAC irrespective
of the wiphy MAC. In OpenWrt, the wlan0 MAC can be supplied and assigned
to a netdev created on a specific wiphy identified by its MAC, and if
that cannot be predicted, there is no wlan0.
the way I read the nl80211 code is that the NL80211_CMD_NEW_INTERFACE requires a wiphy device to be specified. And that is actually just a number. So I have no idea what the MAC has to here.
quoted
So I am still saying that when you do NL80211_CMD_NEW_INTERFACE allow
providing NL80211_ATTR_MAC to set the MAC address to be used. It might
be useful that the wiphy exposes an attribute saying that it does not
have a default MAC address, but that should be it. I do not like these
magic 00:00:00:00:00:00 games. As I mentioned earlier, in Bluetooth we
just deal with allowing the driver to set a flag that it does not have
a valid address. And then the core takes care of dealing with it.
An attribute saying there is no default MAC is helpful only if there is
a way to supply a new default to the wiphy.
Why does the wiphy need to know the MAC if it is always specified from userspace when actually creating the new netdev interface. Works for P2P devices, so why wouldn't it work for access point and station mode?

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help