Re: [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload

On 08/24/14 22:24, Scott Feldman wrote:

On Aug 24, 2014, at 8:15 AM, Jamal Hadi Salim [off-list ref] wrote:

With respect to focus on L2/L3, I have a pretty *good* hunch someone could

 > write a kernel module that gleans from the L2/L3 netlink echoes 
already flying

around and translates to sw_flows and in turn into ndo_swdev_flow_* calls.

And herein lies the fundamental disagreement.
I dont believe the flow interface is appropriate for either L2/3.
We already have some L2 interfaces (they are incomplete if you want
to capture everything a large switch does).
L3 should go the same path.

And as i said earlier, i dont think the flow interface
is appropriate as a universal classifier interface either.
You need to allow for different types of classifiers. You
need to allow for a mix and match of classifiers (although
the later could be evolutionary).

cheers,
jamal