Re: [patch net-next RFC 12/12] rocker: introduce rocker switch driver
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2014-08-21 17:20:19
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2014-08-21 17:20:19
2014-08-21 9:19 GMT-07:00 Jiri Pirko [off-list ref]:
This patch introduces the first driver to benefit from the switchdev infrastructure and to implement newly introduced switch ndos. This is a driver for emulated switch chip implemented in qemu: https://github.com/sfeldma/qemu-rocker/ This patch is a result of joint work with Scott Feldman.
You could eliminate a lot of boilerplate code that delegates ethtool/netdev operations from the network interface to the switch driver if you made this a DSA driver, without registering a tag protocol or by reworking that. Other than that, this is a really nice piece of driver you got here, it's definitively a clean design. Thanks! -- Florian