Thread (11 messages) 11 messages, 5 authors, 2014-08-27

RE: [PATCH net-next v3 0/3] enic: Add support for rx_copybreak

From: Govindarajulu Varadarajan <hidden>
Date: 2014-08-15 20:22:00

On Thu, 14 Aug 2014, David Laight wrote:
Is there any mileage in having a system-wide default for rx_copybreak?
I'd have thought that the value is really driver independent since it
(mostly) depends on the comparative cost of dma_map and copy operations.
The cost skb_alloc(small_size) and memcpy(small_size) should be completely
independent of driver.

The cost of dma_unmap(mtu) , skb_alloc(mtu) & dma_map(mtu) determines the break
point. This operation should take less time for smaller mtu size,
and more time for larger mtu size. (especially for 9k mtu as we do not have
generic kmem_cache for size above 8192)

mtu of 9k is quite common for enic in data center. So rx_copybreak can go till
254. Most of the drivers use 100 as the copybreak, I guess thats because 1500
mtu is common for those nics and probably 100 is the break point.

Some driver allocates frags of pages, instead of contiguous memory.
I think it's better to leave the default to driver.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help