Re: [PATCH] asix - Add support for LyconSys FiberGecko
From: Sergei Shtylyov <hidden>
Date: 2014-08-07 16:33:57
Hello. On 08/07/2014 07:53 PM, David Hollis wrote:
Reported-by: Sven Kreiensen <redacted> Signed-off-by: David Hollis <redacted>
--- drivers/net/usb/asix_devices.c | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 5d19409..d09f2ea 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c
[...]
quoted hunk ↗ jump to hunk
@@ -648,6 +648,12 @@ static int ax88178_reset(struct usbnet *dev) asix_sw_reset(dev, 0); msleep(150); + /* LyconSys FiberGecko: Turn on PHY */ + if (dev->driver_info->flags == 0x20061201) {
Hm, don't use magic values please. Doesn't the flags get assigned a
combination of FLAG_* values below? Or you mixed up 'flags' and 'data' fields?
quoted hunk ↗ jump to hunk
+ /* Power on Phy: set gpio2=high */ + asix_write_gpio(dev, AX_GPIO_GPO2EN | AX_GPIO_GPO_2, 50); + } + asix_sw_reset(dev, AX_SWRESET_PRL | AX_SWRESET_IPPD); msleep(150);@@ -946,6 +952,19 @@ static const struct driver_info hg20f9_info = { .data = FLAG_EEPROM_MAC, }; +static const struct driver_info lyconsys_fibergecko100_info = { + .description = "LyconSys FiberGecko 100 USB 2.0 to Ethernet Adapter", + .bind = ax88178_bind, + .status = asix_status, + .link_reset = ax88178_link_reset, + .reset = ax88178_link_reset, + .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR | + FLAG_MULTI_PACKET, + .rx_fixup = asix_rx_fixup_common, + .tx_fixup = asix_tx_fixup,
Hm, why this sudden change of the initializer style?
+ .data = 0x20061201, +}; +
WBR, Sergei