Re: [PATCH net-next] ipv6: rename __ipv6_addr_jhash()
From: Eric Dumazet <hidden>
Date: 2014-08-01 06:46:20
From: Eric Dumazet <hidden>
Date: 2014-08-01 06:46:20
On Thu, 2014-07-31 at 21:56 -0700, David Miller wrote:
From: Eric Dumazet <redacted> Date: Wed, 30 Jul 2014 23:38:18 +0200quoted
From: Eric Dumazet <edumazet@google.com> Remove '__' prefix, it has no purpose. Signed-off-by: Eric Dumazet <edumazet@google.com>Actually, I think it does. If you look at where this came from, it's commit: commit b50026b5ac8fe2932e6af0c54b21da0913c4c1c7 Author: Hannes Frederic Sowa [off-list ref] Date: Sat Oct 19 21:48:52 2013 +0200 ipv6: split inet6_ehashfn to hash functions per compilation unit and in that change Hannes uses the convention that __foo() functions take an initval argument for the hash computation where as foo() functions do not. I'm not applying this, sorry :)
Well, there is no ipv6_addr_jhash() anymore. Should we rename jhash() to __jhash() then ???? This seems pretty odd and useless.