Re: [PATCH RFC V2 2/2] net: qualcomm: new Ethernet over SPI driver for QCA7000

On Tue, 2014-07-01 at 18:46 +0100, Mark Rutland wrote:

On Tue, Jul 01, 2014 at 05:36:49PM +0100, Stefan Wahren wrote:

quoted

This patch adds the Ethernet over SPI driver for the
Qualcomm QCA7000 HomePlug GreenPHY.

[]

quoted

+               memcpy(qca->net_dev->dev_addr, mac, ETH_ALEN);

I believe that it is preferred to write:

	ether_addr_copy(qca->net_dev->dev_addr, mac);

I believe checkpatch has a warning for this.

True, but you have to make sure that both args are
at least __aligned(2) and afaics there's no
guarantee that's true for mac.