Re: Re: [PATCH net-next] pktgen: add ttl option for pktgen
From: Zhouyi Zhou <hidden>
Date: 2014-07-30 12:57:11
Also in:
lkml
Thanks for reviewing. I did miss it.
quoted hunk ↗ jump to hunk
-----Original Messages----- From: "Dmitry Popov" <redacted> Sent Time: Wednesday, July 30, 2014 To: "Zhouyi Zhou" <redacted> Cc: rdunlap@infradead.org, davem@davemloft.net, minipli@googlemail.com, brouer@redhat.com, steffen.klassert@secunet.com, fan.du@windriver.com, dborkman@redhat.com, fengguang.wu@intel.com, tgraf@suug.ch, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Zhouyi Zhou" <redacted> Subject: Re: [PATCH net-next] pktgen: add ttl option for pktgen On Wed, 30 Jul 2014 16:21:26 +0800 Zhouyi Zhou [off-list ref] wrote:quoted
I think it is useful to add ttl option for pktgen, for example if a some ISP want to test its network quality, it could set ttl so that the tested links get the packet while end users won't get it.It seems you're missing--- a/net/core/pktgen.c +++ b/net/core/pktgen.c@@ -2799,7 +2799,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev, iph->ihl = 5; iph->version = 4; - iph->ttl = 32; + iph->ttl = pkt_dev->ttl; iph->tos = pkt_dev->tos; iph->protocol = IPPROTO_UDP; /* UDP */ iph->saddr = pkt_dev->cur_saddr;