Re: [PATCH net-next v9 2/9] net: nl80211 - make rdev_add_virtual_intf take name_assign_type

On Thu, 2014-07-17 at 11:16 +0200, Tom Gundersen wrote:

quoted

quoted

 static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy,
                                                    const char *name,
+                                                   unsigned char name_assign_type,

unsigned char for an enum is really odd.

Hm, this was based on the addr_assign_type attribute, which also is an
unsigned char (and serves a very similar purpose).

Out of interest, what would you have preferred (and why)?

Even if it eventually ends up being assigned to a u8 or something, it
seems passing it around as an enum makes the interfaces better?

johannes