Thread (2 messages) flat view 2 messages, 2 authors, 2014-07-14

Re: [PATCH] Bluetooth: cmtp: Remove unnecessary null test

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2014-07-14 21:02:22
Also in: linux-bluetooth, lkml

Hi Himangi,
This patch removes the null test on ctrl. ctrl is initialized at the
beginning of the function to &session->ctrl. Since session is
dereferenced prior to the null test, session must be a valid pointer,
and &session->ctrl cannot be null.

The following Coccinelle script is used for detecting the change:

@r@
expression e,f;
identifier g,y;
statement S1,S2;
@@

*e = &f->g
<+...
f->y
...+>
*if (e != NULL || ...)
S1 else S2

Signed-off-by: Himangi Saraogi <redacted>
Acked-by: Julia Lawall <redacted>
---
net/bluetooth/cmtp/capi.c | 6 ------
1 file changed, 6 deletions(-)
patch has been applied to bluetooth-next tree.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help