Thread (25 messages) 25 messages, 5 authors, 2014-07-07

Re: [PATCH v2] declance: Fix 64-bit compilation warnings

From: Maciej W. Rozycki <hidden>
Date: 2014-07-05 20:25:55
Also in: lkml

On Sat, 5 Jul 2014, Joe Perches wrote:
quoted
quoted
I don't think %#p is valid so it
shouldn't have been set by #.
 Huh?  As recently as last Wednesday you pointed me at the specific commit 
from Grant that made it valid (GCC format complaints aside).
Those gcc complaints are precisely the thing
that makes it invalid.
 So enforce that in code then, clear the SPECIAL flag where appropriate 
and do not try to handle it in one place while leaving other ones to 
behave randomly (i.e. a supposedly fixed field width varies depending on 
the two uppermost digits).  Please note that it's only your proposed 
change that introduces that randomness, right now code does what's 
supposed and documented to, except a bit inconsistently.
I believe you're tilting at windmills.

Hey, it works sometimes.  Knock yourself out.
 I pointed out an inconsistency with the intent to propose a fix once a 
consensus have been reached, one way or another.  And I think shifting the 
inconsistency to a different place, which is what your proposal does, 
isn't really a complete solution, although I do recognise the improvement.

  Maciej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help