Thread (7 messages) 7 messages, 2 authors, 2014-07-30

Re: [PATCH net-next 1/3] mlx5: Move pci device handling from mlx5_ib to mlx5_core

From: Eli Cohen <hidden>
Date: 2014-07-30 10:26:21

On Mon, Jul 28, 2014 at 11:57:37PM +0300, Or Gerlitz wrote:
You need to issue a warning here if someone attempts to change the
previously default value of the now deprecated module param. E.g warn
this is deprecated and point them to mlx5_core
It is handled in the module init function:

static int __init mlx5_ib_init(void)
{
-       return pci_register_driver(&mlx5_ib_driver);
+       if (deprecated_prof_sel != 2)
+               pr_warn("prof_sel is deprecated for mlx5_ib, set it
for mlx5_core\n");
+
+       return mlx5_register_interface(&mlx5_ib_interface);
}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help