Thread (6 messages) 6 messages, 3 authors, 2014-07-31

Re: [PATCH net v5 0/3] net: libphy: Add phy specific functions to access mmd regs

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2014-07-29 21:30:34

2014-07-29 13:19 GMT-07:00 Vince Bridgers [off-list ref]:
This set of patches addresses a problem found with the Micrel ksz9021 phy and
libphy, where the ksz9021 phy does not support mmd extended register access
per the IEEE specification as assumed by libphy. The first patch adds a
framework for phy specific support to specify their own function to access
extended phy registers, return a failure code if not supported, or to default
to libphy's IEEE defined method for accessing the mmd extended phy registers.

This issue was found by using the Synopsys EMAC and a Micrel ksz9021 phy on the
Altera Cyclone 5 SOC development kit. This patch was tested on the same system
in both positive and negative test cases.
Thanks for putting this together, this looks good to me now!
---
V5: Revert name of mmd register access functions, check for phy specific
    driver override functions in mmd register access functions per
    Florian's comments to minimize source code changes
V4: Correct error when formatting V3 patch - erroneous text cut from code
V3: Correct formatting of function arguments, remove return statement from
    NULL functions, and add patch for PHY driver documentation per review
    comments.
V2: Split the original patch submission into seperate patches for the libphy
    framework required for the modification and for the Micrel Phy.

Vince Bridgers (3):
  net: libphy: Add phy specific function to access mmd phy registers
  net: libphy: Add stubs to hook IEEE MMD Register reads and writes
  Documentation: networking: phy.txt: Update text for indirect MMD
    access

 Documentation/networking/phy.txt |   18 ++++++++++-
 drivers/net/phy/micrel.c         |   22 ++++++++++++++
 drivers/net/phy/phy.c            |   61 ++++++++++++++++++++++++--------------
 include/linux/phy.h              |   18 +++++++++++
 4 files changed, 95 insertions(+), 24 deletions(-)

--
1.7.9.5


-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help