Re: [PATCH] ip_tunnel(ipv4): fix tunnels with "local any remote $remote_ip"
From: David Miller <davem@davemloft.net>
Date: 2014-07-28 23:44:33
From: David Miller <davem@davemloft.net>
Date: 2014-07-28 23:44:33
From: Cong Wang <redacted> Date: Mon, 28 Jul 2014 16:39:23 -0700
On Mon, Jul 28, 2014 at 4:07 PM, Dmitry Popov [off-list ref] wrote:quoted
--- a/include/net/ip_tunnels.h +++ b/include/net/ip_tunnels.h@@ -40,6 +40,7 @@ struct ip_tunnel_prl_entry { struct ip_tunnel_dst { struct dst_entry __rcu *dst; + __be32 saddr; };It looks odd to save a source address in some struct named dst, maybe it's the time to rename it.
It's an encapsulation struct for plain "struct dst_entry", which is a path to a destination, or in other words a "route". A "saddr" is a valid key for a route. I see no reason to change the name of this structure, it's perfect.