Re: [PATCH] netfilter: nf_sockopt_find() should return ERESTARTSYS
From: Eric Dumazet <hidden>
Date: 2014-07-24 20:35:05
Also in:
netfilter-devel
From: Eric Dumazet <hidden>
Date: 2014-07-24 20:35:05
Also in:
netfilter-devel
On Thu, 2014-07-24 at 18:19 +0100, Patrick McHardy wrote:
On 23. Juli 2014 23:53:15 GMT+01:00, Eric Dumazet [off-list ref] wrote:quoted
From: Eric Dumazet <edumazet@google.com> getsockopt() or setsockopt() sometimes returns -EINTR instead of -ENOPROTOOPT, causing headaches to application developers. This is because unsupported commands might go through nf_sockopt_find() and this function returns -EINTR instead of -ERESTARTSYS if a signal is pending.I'd propose to simply use the non interruptable mutex functions. We have many instances where this is really completely unnecessary. I can take care of this (once my notebook has been repaired).
No problem I'll send a v2, thanks.