Re: [net-next 03/10] vxlan: Remove vxlan_get_rx_port()

You are right.  Thanks for pointing this out. I will swap it in the
next version.

On Tue, Jul 22, 2014 at 7:20 PM, Alexander Duyck
[off-list ref] wrote:

On Tue, Jul 22, 2014 at 3:19 AM, Andy Zhou [off-list ref] wrote:

quoted

Instead of specificly calling vxlan_get_rx_port(), Device driver
should now call udp_tunnel_get_rx_port() instead.  Making this change
to support future NICs and device drivers that may support more
UDP tunnel protocol offloads.

Signed-off-by: Andy Zhou <redacted>
---
 drivers/net/ethernet/emulex/benet/be_main.c      |    2 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c      |    2 +-
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c   |    2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c |    2 +-
 drivers/net/vxlan.c                              |   26
----------------------
 include/net/vxlan.h                              |    7 ------
 6 files changed, 4 insertions(+), 37 deletions(-)

If I am not mistaken I think this patch is incomplete.  There is nothing
that is currently initializing the tunnel type for VXLAN until the next
patch.  As such I believe this patch breaks the functionality.  You might
want to consider swapping it with patch 4 in order to avoid that.

Thanks,

Alex