Re: [PATCH v2 net-next 1/2] net: use dev->name in netdev_pr* when it's available
From: Joe Perches <joe@perches.com>
Date: 2014-07-17 16:58:22
On Thu, 2014-07-17 at 18:38 +0200, Veaceslav Falico wrote:
On Thu, Jul 17, 2014 at 09:36:08AM -0700, Joe Perches wrote:quoted
On Thu, 2014-07-17 at 18:25 +0200, Veaceslav Falico wrote:quoted
On Thu, Jul 17, 2014 at 09:18:44AM -0700, Joe Perches wrote:quoted
On Thu, 2014-07-17 at 16:09 +0200, Veaceslav Falico wrote:quoted
netdev_name() returns dev->name only when the net_device is in NETREG_REGISTERED state.[]quoted
quoted
Maybe this should not be inline and become something like:It will miss the states then, when it's not NETREG_REGISTERED.If it's registered, it has a valid name via dev_get_valid_name() doesn't it?Yes, I'm speaking about the NETREG_* states when it's not registered. i.e.: Jul 17 13:35:29 darkmag kernel: [ 602.686489] bond2 (unregistering): Released all slaves
OK, I hadn't read the patch where netdev_reg_state was emitted. Still, it's probably smaller overall code to uninline it now.