Re: [PATCH net-next 2/2] bonding: make hard-coded defines configurable at build
From: Alexei Starovoitov <hidden>
Date: 2014-07-15 15:48:02
On Tue, Jul 15, 2014 at 3:15 AM, Veaceslav Falico [off-list ref] wrote:
quoted hunk ↗ jump to hunk
CC: Jay Vosburgh <redacted> CC: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Veaceslav Falico <redacted> --- drivers/net/bonding/Kconfig | 16 ++++++++++++++++ drivers/net/bonding/bonding.h | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-)diff --git a/drivers/net/bonding/Kconfig b/drivers/net/bonding/Kconfig index 7b1a0fa..28fb3af 100644 --- a/drivers/net/bonding/Kconfig +++ b/drivers/net/bonding/Kconfig@@ -15,3 +15,19 @@ menuconfig BONDING To compile this driver as a module, choose M here: the module will be called bonding. + +if BONDING + +config BOND_MAX_VLAN_ENCAP + int "Maximum number of stacked vlans on top of bonding" + default "2" +
I don't think we should allow changing these defaults so easily. Not a single HW supports 3 vlan tags. There is no standard for it either. Why you would ever change this?
+config BOND_MAX_ARP_TARGETS + int "Maximum number of ip targets arp monitor supports" + default "16" + +config BOND_DEFAULT_MIIMON + int "Default miimon monitoring frequency in milliseconds" + default "100"
or this? imo existing built-ins are fine and adding extra knobs just scary. Users will have different numbers here and somebody would need to make sure that all different defaults still work. We should be minimizing the number of knobs instead.