Thread (9 messages) flat view 9 messages, 5 authors, 2014-07-15

Re: [PATCH 1/2 net-next] vxlan: Be liberal on receive and only require the I bit to be set

From: Thomas Graf <tgraf@suug.ch>
Date: 2014-07-11 21:28:15

On 07/11/14 at 12:41pm, Stephen Hemminger wrote:
On Fri, 11 Jul 2014 18:59:49 +0200
Thomas Graf [off-list ref] wrote:
quoted
@@ -1617,7 +1646,9 @@ static int vxlan6_xmit_skb(struct vxlan_sock *vs,
 	}
 
 	vxh = (struct vxlanhdr *) __skb_push(skb, sizeof(*vxh));
-	vxh->vx_flags = htonl(VXLAN_FLAGS);
+	vxlan_flags(vxh) = VXLAN_FLAG_VNI;
+	vxh->vx_reserved1 = 0;
+	vxh->vx_reserved2 = 0;
 	vxh->vx_vni = vni;
 
 
Okay, but initializing bitfields generates crappy code.
Can we just alias and do one assignment.
Sure, I'll resend.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help