Re: [PATCH 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag
From: Alexei Starovoitov <hidden>
Date: 2014-06-24 15:29:59
Also in:
linuxppc-dev
On Tue, Jun 24, 2014 at 2:59 AM, Denis Kirjanov [off-list ref] wrote:
Use the proper mask which is 0xefff
sob is missing. also please expand the commit message a bit, otherwise it's too cryptic for folks who don't know bpf details.
quoted hunk ↗ jump to hunk
--- arch/powerpc/net/bpf_jit_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c index 6dcdade..af0ed4d 100644 --- a/arch/powerpc/net/bpf_jit_comp.c +++ b/arch/powerpc/net/bpf_jit_comp.c@@ -393,7 +393,7 @@ static int bpf_jit_build_body(struct sk_filter *fp, u32 *image, PPC_LHZ_OFFS(r_A, r_skb, offsetof(struct sk_buff, vlan_tci)); if (code == (BPF_ANC | SKF_AD_VLAN_TAG)) - PPC_ANDI(r_A, r_A, VLAN_VID_MASK); + PPC_ANDI(r_A, r_A, ~VLAN_TAG_PRESENT); else PPC_ANDI(r_A, r_A, VLAN_TAG_PRESENT); break; --2.0.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html