Thread (11 messages) 11 messages, 4 authors, 2014-06-17

Re: netconsole breaks netpoll on bridge

From: Neil Horman <nhorman@tuxdriver.com>
Date: 2014-06-17 11:40:22
Also in: bridge, lkml

On Tue, Jun 17, 2014 at 08:06:58AM +0200, Stefan Priebe - Profihost AG wrote:
Am 16.06.2014 23:30, schrieb Francois Romieu:
quoted
Stefan Priebe - Profihost AG [off-list ref] :
[...]
quoted
That sounds great! Is there anything I can do or some code I can port to veth?
You may add an empty handler for .ndo_poll_controller in drivers/net/veth.c
and give it a try on current kernel.

It should not be too bad.
Why is an empty poll controller enough to fix it? This sounds a bit
crazy to me.
Because the presence of a non-null poll_controller method is how we determine if
a device supports netpoll.  Most devices require a ndo_poll_controller function
to simulate an interrupt for receiving packets, but virtual devices really
don't, so an empty function sufficies to get the device recognized as having
netpoll support.  See tun_poll_controller as an example
Neil
Greets,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help