Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

Hello,

quoted

IN6_DEV_MAXCONF
      IN6_DEV_HOPLIMIT
      IN6_DEV_MTU

I'm a little bit surprise to set the MTU as the maximum of all/dev
value. Since the default for "all" is IPV6_MIN_MTU, it is probably
harmless, but it could be a little bit surprising for administrators.

quoted

 IN6_DEV_USE_TEMPADDR

For this one, the default is zero, except for point-to-point and
loopback, with -1. I didn't see any difference between 0 and -1 in the
current kernel code, but if I missed something, it could be a little
problem.

Hi,

these are both valid points. It does not make too much sense to get
max value for MTU and I'd say we should either get min or simply get
interface setting and don't change the current behavior for this particular
one.

use_tempaddr will have special treatment too since it can range from:
use_tempaddr - INTEGER
    Preference for Privacy Extensions (RFC3041).
      <= 0 : disable Privacy Extensions
      == 1 : enable Privacy Extensions, but prefer public
             addresses over temporary addresses.
      >  1 : enable Privacy Extensions and prefer temporary
             addresses over public addresses.
    Default:  0 (for most devices)
         -1 (for point-to-point devices and loopback devices)

Milos