RE: [PATCH 0/10] use safer test on the result of find_first_zero_bit

From
David Laight <hidden>
Date
2014-06-04 13:34:39
Also in
kernel-janitors, linux-fbdev, linux-rdma, linux-s390, linux-scsi, linux-sh, linux-wireless, lkml
Reply to
Julia Lawall, 2014-06-04
From: Julia Lawall
On Wed, 4 Jun 2014, Geert Uytterhoeven wrote:
quoted
Hi Julia,

On Wed, Jun 4, 2014 at 1:00 PM, Julia Lawall [off-list ref] wrote:
quoted
OK, thanks.  I was only looking at the C code.

But the C code contains a loop that is followed by:

        if (!size)
                return result;
        tmp = *p;

found_first:
        tmp |= ~0UL << size;
        if (tmp == ~0UL)        /* Are any bits zero? */
                return result + size;   /* Nope. */

In the first return, it would seem that result == size.  Could the second
one be changed to just return size?  It should not hurt performance.
"size" may have been changed between function entry and this line.
So you have to store it in a temporary.
Sorry, after reflection it seems that indeed size + result is always the
original size, so it is actually all of the code that uses >= that is
doing something unnecessary.  == for the failure test is fine.
There is nothing wrong with defensive coding.
The 'tmp |= ~0UL << size' ensures that the return value is 'correct'
when there are no bits set.
The function could have been defined so that this wasn't needed.

If you assume that the 'no zero bits' is unlikely, then checking the
return value from ffz() could well be slightly faster.
Not that anything is likely to notice.

	David


Thread (11 messages) 11 messages, 3 authors, last reply 2014-06-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help