On 06/03/2014 08:48 AM, Paolo Bonzini wrote:

Il 02/06/2014 23:58, Eric Dumazet ha scritto:

quoted

This looks dubious

What about using kfree_rcu() instead ?

It would lead to unbound allocation from userspace.

quoted

translate_desc() still uses rcu_read_lock(), its not clear if the mutex
is really held.

Yes, vhost_get_vq_desc must be called with the vq mutex held.

The rcu_read_lock/unlock in translate_desc is unnecessary.

If that's true, then does dev->memory really needs to be rcu protected?
It appears to always be read under mutex.

-vlad

Paolo
-- 
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html