Thread (2 messages) flat view 2 messages, 2 authors, 2014-06-02

Re: [PATCH] stmmac: Remove spin_lock call in stmmac_get_pauseparam()

From: David Miller <davem@davemloft.net>
Date: 2014-06-02 17:38:37
Also in: kernel-janitors, lkml

From: Emil Goode <redacted>
Date: Mon,  2 Jun 2014 11:30:50 +0200
The following patch removed unnecessary spin_lock/unlock calls
in ethtool_ops callback functions. In the second and final version
of the patch one spin_lock call was left behind.

commit cab6715c3e8029e98b0b5d4056ceda007c0f6380
Author: Yang Wei [off-list ref]
Date:   Sun May 25 09:53:44 2014 +0800

    net: driver: stmicro: Remove some useless the lock protection

This introduced the following sparse warning:

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
	context imbalance in 'stmmac_get_pauseparam' -
	different lock contexts for basic block

Signed-off-by: Emil Goode <redacted>
Good catch, applied, thanks Emil.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help