Re: [PATCH] atm: fore200e.c: Cleaning up uninitialized variables
flat view
From: Olof Johansson <hidden>
Date: 2014-06-02 00:10:42
Also in:
linux-devicetree, lkml
On Sat, May 31, 2014 at 4:08 PM, Rickard Strandqvist [off-list ref] wrote:
quoted hunk ↗ jump to hunk
There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <redacted> --- drivers/atm/fore200e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index 204814e..d4725fc 100644 --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore200e.c@@ -2780,7 +2780,7 @@ static struct pci_driver fore200e_pca_driver = { static int __init fore200e_module_init(void) { - int err; + int err = 0; printk(FORE200E "FORE Systems 200E-series ATM driver - version " FORE200E_VERSION "\n");
I can see how a tool that doesn't know about Kconfig dependencies might think so, but if you look at Kconfig you'll see that for this driver to be enabled for building either CONFIG_SBUS or CONFIG_PCI must be set, and if either of them is then this variable will not be used without first being set. -Olof