Re: [PATCH 4/11] via-ircc: Remove useless return variables

On Sun, Jun 01, 2014 at 01:42:30PM +0200, walter harms wrote:

quoted

quoted

 static int via_ircc_read_dongle_id(int iobase)
-{
-	int dongle_id = 9;	/* Default to IBM */
-
+{/* Default to IBM */

Yuck.  And anyway, the comment should be on return line.  (And of course
there should have been a #define IBM_DONGLE_ID 9, but that's probably
something for another patch.

quoted

 	IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n");
-	return dongle_id;
+	return 9;

more over code and error msg do not fit,
it returns a default of 9 (what ever that means) it does not look like
an error. Sow the warning should be

via-ircc: dongle probing not supported, please specify dongle_id module parameter. settting dongle_id=9

The print is ok.  It's called like this:

   328          /* Check if user has supplied the dongle id or not */
   329          if (!dongle_id)
   330                  dongle_id = via_ircc_read_dongle_id(self->io.fir_base);
   331          self->io.dongle_id = dongle_id;

If you don't use a module id then it acts like an IBM dongle by default.

regards,
dan carpenter