Thread (5 messages) 5 messages, 3 authors, 2014-06-30

Re: [PATCH] declance: Fix 64-bit compilation warnings

From: Maciej W. Rozycki <hidden>
Date: 2014-06-29 01:30:58

On Sat, 28 Jun 2014, Joe Perches wrote:
quoted
@@ -499,8 +499,9 @@ static void lance_init_ring(struct net_d
 						/* The ones required by tmd2 */
 		*lib_ptr(ib, btx_ring[i].misc, lp->type) = 0;
 		if (i < 3 && ZERO)
-			printk("%d: 0x%8.8x(0x%8.8x)\n",
-			       i, leptr, (uint)lp->tx_buf_ptr_cpu[i]);
+			printk("%d: 0x%8.8x(%#0*lx)\n",
+			       i, leptr, (int)sizeof(long),
+			       (long)lp->tx_buf_ptr_cpu[i]);
You need to adjust the "*" and sizeof(long) with +2 for the
0x prefix in the output length here.
 Good catch, thanks!  MIPS kernel addresses always have their MSB set so 
this is hard to notice in testing.  But also the width has to be doubled 
first, to take two digits per byte into account too.  Sending an updated 
change right away, as soon as it builds and boots.

  Maciej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help