Thread (5 messages) flat view 5 messages, 2 authors, 2014-06-27

Re: [net-next PATCH v3 2/2] bridge: netlink dump interface at par with brctl

From: David Miller <davem@davemloft.net>
Date: 2014-06-27 00:45:31

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Wed, 25 Jun 2014 06:21:23 -0400
+				/* 
+				 * !f->dst is a speacial case for bridge
+				 * It means the MAC belongs to the bridge
+				 * Therefore need a little more filtering
+				 * we only want to dump the !f->dst case
+				 */
Please format comments:

	/* Like
	 * this.
	 */

in the networking.
+	for_each_netdev(net, dev) {
+
+		if (brport_idx && (dev->ifindex != brport_idx))
Please remove that empty line.
+			if (cops && cops->ndo_fdb_dump) {
+				idx = cops->ndo_fdb_dump(skb, cb, br_dev, dev, idx);
+			}
Single statement basic blocks do not need curly braces.
+		if (dev->netdev_ops->ndo_fdb_dump) {
+			idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, bdev, dev,
+							    idx);
 		}
Likewise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help