Thread (5 messages) flat view 5 messages, 3 authors, 2014-06-26

Re: [patch net-next v2 1/2] rtnetlink: allow to register ops without ops->setup set

From: Jiri Pirko <jiri@resnulli.us>
Date: 2014-06-26 07:46:35

Wed, Jun 25, 2014 at 08:45:00PM CEST, stephen@networkplumber.org wrote:
On Wed, 25 Jun 2014 18:58:22 +0200
Jiri Pirko [off-list ref] wrote:
quoted
So far, it is assumed that ops->setup is filled up. But there might be
case that ops might make sense even without ->setup. In that case,
forbid to newlink and dellink.

This allows to register simple rtnl link ops containing only ->kind.
That allows consistent way of passing device kind (either device-kind or
slave-kind) to userspace.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Can't we fix these kind of devices to all create/delete. At least
allow delete.
Well it is not that easy to create openvswitch device. To do that you
have to have info specified in vport_params (see ovs_vport_alloc).

Delete could be implemented. But looking at the code, it could be a bit
tricky. But would that make sense to implement del and don't implement
add? I think it's better to leave both out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help