Re: [net-next PATCH v2 2/2] bridge: netlink dump interface at par with brctl

On Tue, 24 Jun 2014 10:15:19 -0400
Jamal Hadi Salim [off-list ref] wrote:

+			if (filter_dev && (!f->dst || f->dst->dev != filter_dev)) {
+				if (filter_dev != dev)
+					goto skip;
+				else {
+					/* 
+					 * !f->dst is a speacial case for bridge
+					 * It means the MAC belongs to the bridge
+					 * Therefore need a little more filtering
+					 * we only want to dump the !f->dst case
+					 */
+					if (f->dst)
+						goto skip;
+				}

After goto, the else is not needed, and it removes one level of already
deep indentation.

		

			if (filter_dev && (!f->dst || f->dst->dev != filter_dev)) {
				if (filter_dev != dev)
					goto skip;
				/* 
				 * !f->dst is a speacial case for bridge
				 * It means the MAC belongs to the bridge
				 * Therefore need a little more filtering
				 * we only want to dump the !f->dst case
				 */
				if (f->dst)
					goto skip;