Thread (12 messages) flat view 12 messages, 2 authors, 2014-06-22

Re: [PATCH net-next v2 8/8] enic: do tx cleanup in napi poll

From: Govindarajulu Varadarajan <hidden>
Date: 2014-06-22 07:26:12


On Sat, 21 Jun 2014, David Miller wrote:
It is recommended that TX work not count against the quota.

The cost of TX packet liberation is a minute percentage of what it
costs to process an RX frame.  Furthermore, that SKB freeing makes
memory available for other paths in the stack.

So please, just unconditionally purge the entire set of pending TX
queue completion entries without regards to the passed in NAPI quota
value at all.
So I should ignore the budget value and clean all packets possible. And what
should the NAPIs return value should be? I can not be > 64 right?

Or should I netif_napi_add() with highest value possible? For enic its 4096.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help