Re: net: return actual error on register_queue_kobjects

On Thu, Jun 19, 2014 at 2:28 PM, Dan Carpenter [off-list ref] wrote:

Hello Jie Liu,

The patch d36a4f4b4723: "net: return actual error on
register_queue_kobjects" from Jun 17, 2014, leads to the following
static checker warning:

        net/core/net-sysfs.c:1203 register_queue_kobjects()
        warn: 'net->queues_kset' isn't an ERR_PTR

net/core/net-sysfs.c
  1200  #ifdef CONFIG_SYSFS
  1201          net->queues_kset = kset_create_and_add("queues",
                                   ^^^^^^^^^^^^^^^^^^^
This function returns a NULL on error doesn't it?  In linux-next it
does.  The patch description is not clear.

that patch is broken and should be reverted as Jeff said:

--
From: Jeff Liu <redacted>

You will have to watch very carefully to ensure that those patches do
not now get accepted, as they will break the existing code.

Ok, and I'll inform every other maintainers do not apply their patch
individually.

Cheers,
-Jeff

--

From: Jeff Liu <redacted>
Yes, could you please remove this patch? sorry for the convenient!

--