Re: [Xen-devel] [PATCH 1/2] xen-netfront: fix oops when disconnected from backend

From
Wei Liu <hidden>
Date
2014-06-18 14:23:10
Reply to
David Vrabel, 2014-06-18
On Wed, Jun 18, 2014 at 10:47:27AM +0100, David Vrabel wrote:
xennet_disconnect_backend() was not correctly iterating over all the
queues.

Signed-off-by: David Vrabel <redacted>
Reviewed-by: Wei Liu <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/net/xen-netfront.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 5a7872a..daaf1e5 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1287,7 +1287,7 @@ static irqreturn_t xennet_rx_interrupt(int irq, void *dev_id)
 
 	if (likely(netif_carrier_ok(dev) &&
 		   RING_HAS_UNCONSUMED_RESPONSES(&queue->rx)))
-			napi_schedule(&queue->napi);
+		napi_schedule(&queue->napi);
 
This indentation fix is not actually related to this bug. IMHO it should
either be removed or noted in commit message.

Wei.
Thread (6 messages) 6 messages, 3 authors, last reply 2014-06-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help