Re: [net-next PATCH 2/2] bridge: netlink dump interface at par with brctl

On 06/10/14 09:25, Vlad Yasevich wrote:

I gave it some thought and I think something like the following
pseudo-code would work.

dump_dev_fdbs(dev, filter)
{
         if (dev->dumper)
                 dev->ndo_dumper(dev, filter);
         else
                 default_dumper(dev, filter);
}

for_each_netdev() {
         if (bridge_filter) {
                 if (dev->index != bridge_filter)
                         skip;

                 dump_dev_fdbs(dev, port_filter);
         } else {
                 if (port_filter) {
                         if (bridge_port &&
                             dev->index != port_filter)
                                 skip;

                 }

                 if (bridge_port) {
                         br_dev = get_bridge();
                         dump_dev_fdbs(br_dev, port_filter);
                 }

                 dump_dev_fdbs(dev, port_filter);
         }
}


What do you think?

Too bad i missed the net-next submission.
I am not sure what you suggest above will improve upon readability,
but i will take another run at it when Dave opens up.
I know reading the patch was hard - the code was not as bad.
We'll see.

cheers,
jamal