Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again

On Tue, 2014-06-10 at 09:44 +0100, Wei Liu wrote:

On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:

quoted

commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
queue struct") added a use of vzalloc/vfree to interface.c, but
removed the #include <linux/vmalloc.h> statement at the same time,
which causes this build error:

drivers/net/xen-netback/interface.c: In function 'xenvif_free':
drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
  vfree(vif->queues);
  ^
cc1: some warnings being treated as errors

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Wei Liu <redacted>
Cc: Andrew J. Bennieston <redacted>

Acked-by: Wei Liu <redacted>

This didn't happen to me when I built it on x86 though. Just curious,
did you build it on othet platform, say, ARM?

Arnd comaintains the arm-soc tree, so that's a pretty good bet ;-)

Ian.