Thread (7 messages) 7 messages, 5 authors, 2014-06-06

RE: [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

From: David Laight <hidden>
Date: 2014-06-06 08:49:21
Also in: bridge

From: David Miller [mailto:davem@davemloft.net]
quoted
br_manage_promisc() incorrectly expects br_auto_port() to return only 0
or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK.

Signed-off-by: Toshiaki Makita <redacted>
I'm applying this as-is for now, even though I saw the other
suggestions in this thread (which BTW didn't get picked up by
patchwork, maybe some of you dropped the Message-Id in your replies by
accident).
I don't have a problem with that.
The condition looks odd, but it is enabling promiscuous mode
if any other ports are in 'auto' mode.
Possibly the comment above made that clear, but it was truncated
in the diffs.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help