Re: [PATCH net-next v2 1/3] macvlan: don't update the uc and vlan list for L2 forwarding offload
From: Vlad Yasevich <hidden>
Date: 2014-06-05 15:09:12
On 06/05/2014 08:01 AM, Ding Tianhong wrote:
If lowerdev supports L2 forwarding offload, no need to set mac address to uc list and vlan list, so also don't do that when the macvlan mac address changes.
Same issue as in v1. Please explain how this actually works, since the new address never makes it to the hw. -vlad
quoted hunk ↗ jump to hunk
Signed-off-by: Ding Tianhong <redacted> --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 453d55a..c3a54a6 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c@@ -515,7 +515,7 @@ static int macvlan_sync_address(struct net_device *dev, unsigned char *addr) struct net_device *lowerdev = vlan->lowerdev; int err; - if (!(dev->flags & IFF_UP)) { + if (!(dev->flags & IFF_UP) || vlan->fwd_priv) { /* Just copy in the new address */ ether_addr_copy(dev->dev_addr, addr); } else {