Thread (7 messages) 7 messages, 3 authors, 2014-06-05

RE: [PATCH net-next] bridge: Fix incorrect judgment of promisc

flat view

From: David Laight <hidden>
Date: 2014-06-05 13:47:59
Also in: bridge

From: Toshiaki Makita 
quoted
A quick truth table:
	auto_cnt	auto_port	set/clear
		0		0	clear
		0		1	clear
		1		0	set
		1		1	clear
		2+		0/1	clear
The last line should be set.
I've clearly not drunk enough coffee today...

I suspect the 0-1 line is impossible.
Since the check is probably for 'any other ports in 'auto' mode'.
So:
	if (auto_cnt - auto_port > 0)
(which is much the same as the original) is a good descriptive test.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help