Re: [PATCH net-next] net: ipconfig: allow IP-Config over DSA devices

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 30 May 2014 11:08:45 -0700

Let me know your thoughts. If you feel like something like:
netdev_is_upper_dev() or something like that is better.

I'm not happy with this change for several reasons.

First, I don't like the idea that ipconfig works for some stacked
devices and not for others.  I'd rather that we simply accept that
direct devices are the only thing supported.

Secondly, the logic in that ipconfig loop is so confusing.  I can't
even figure out what that dsa pointer test is trying to really
accomplish in the second hunk of your patch.

I'd like to defer this for now, sorry.