Re: [PATCH V2 2/2] bnx2x: Fix kernel crash and data miscompare after EEH recovery

Quoting Dmitry Kravkov [off-list ref]:

On Jun 2, 2014 5:26 AM, David Miller [off-list ref] wrote:

quoted

From: wenxiong@linux.vnet.ibm.com
Date: Wed, 28 May 2014 10:56:43 -0500

quoted

A rmb() is required to ensure that the CQE is not read before it
is written by the adapter DMA.  PCI ordering rules will make sure
the other fields are written before the marker at the end of struct
eth_fast_path_rx_cqe but without rmb() a weakly ordered processor can
process stale data.

Without the barrier we have observed various crashes including
bnx2x_tpa_start being called on queues not stopped (resulting in message
start of bin not in stop) and NULL pointer exceptions from bnx2x_rx_int.

Signed-off-by: Milton Miller <redacted>

Wen, are you sure the addressee is correct? Our mail server was  
unable to deliver.

I didn't see the failure when I submitted the patch. I checked with Milton.
  The domain was sold recently.

Thanks,
Wendy

________________________________

This message and any attached documents contain information from  
QLogic Corporation or its wholly-owned subsidiaries that may be  
confidential. If you are not the intended recipient, you may not  
read, copy, distribute, or use this information. If you have  
received this transmission in error, please notify the sender  
immediately by reply e-mail and then delete this message.