Re: [PATCH 1/13] libertas: make return of 0 explicit
From: Sergei Shtylyov <hidden>
Date: 2014-05-19 12:45:09
Also in:
kernel-janitors, linux-wireless, lkml
Hello. On 19-05-2014 8:31, Julia Lawall wrote:
From: Julia Lawall <redacted>
Delete unnecessary local variable whose value is always 0 and that hides the fact that the result is always 0.
A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r exists@ local idexpression ret; expression e; position p; @@ -ret = 0; ... when != ret = e return - ret + 0 ; // </smpl>
Signed-off-by: Julia Lawall <redacted>
--- Alternatively, was an error code intended in the bad length case, as is done in process_brxed_802_11_packet?
drivers/net/wireless/libertas/rx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c index c7366b0..807c5b8 100644 --- a/drivers/net/wireless/libertas/rx.c +++ b/drivers/net/wireless/libertas/rx.c
[...]
quoted hunk ↗ jump to hunk
@@ -154,10 +152,9 @@ int lbs_process_rxed_packet(struct lbs_private *priv, struct sk_buff *skb) else netif_rx_ni(skb); - ret = 0; done: - lbs_deb_leave_args(LBS_DEB_RX, "ret %d", ret); - return ret; + lbs_deb_leave_args(LBS_DEB_RX, "ret %d", 0);
Why not just "ret 0"?
+ return 0;
WBR, Sergei