Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings()

[PATCH 0/3] cnic fixes. · Michael Chan <mchan@broadcom.com> · 2014-05-30
[PATCH 1/3] cnic: Don't take rcu_read_lock in cnic_rcv_netevent() · Michael Chan <mchan@broadcom.com> · 2014-05-30
[PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Michael Chan <mchan@broadcom.com> · 2014-05-30
[PATCH 3/3] cnic: Fix missing ISCSI_KEVENT_IF_DOWN message · Michael Chan <mchan@broadcom.com> · 2014-05-30
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Benjamin Poirier <hidden> · 2014-05-30
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Michael Chan <mchan@broadcom.com> · 2014-06-02
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Benjamin Poirier <hidden> · 2014-06-02
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Benjamin Poirier <hidden> · 2014-05-30
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Michael Chan <mchan@broadcom.com> · 2014-05-31
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Neil Horman <nhorman@tuxdriver.com> · 2014-05-31
Re: [PATCH 2/3] cnic: Don't take cnic_dev_lock in cnic_alloc_uio_rings() · Michael Chan <mchan@broadcom.com> · 2014-06-01
Re: [PATCH 0/3] cnic fixes. · David Miller <davem@davemloft.net> · 2014-06-02
Re: [PATCH 0/3] cnic fixes. · David Miller <davem@davemloft.net> · 2014-06-02
Re: [PATCH 0/3] cnic fixes. · Michael Chan <mchan@broadcom.com> · 2014-06-03

From: Benjamin Poirier <hidden>
Date: 2014-05-30 22:33:23

On 2014/05/30 16:18, Michael Chan wrote:

We are allocating memory with GFP_KERNEL under spinlock.  Since this is
the only call manipulating the cnic_udev_list and it is always under
rtnl_lock, cnic_dev_lock can be safely removed.

In that case, the many other instances of cnic_dev_lock throughout cnic
should also be removed, no?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help